feat: relax the region constraint for the Substrait.PlanOp
#172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshaaban01
changed the title
Substrait.PlanOpSubstrait.PlanOp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The region of the
Substrait.PlanOpis not strictly limited to theRelationBodyOp's, it is notAnyRegion. This is done to enable dialect conversion between Substrait and GoogleSQL (which now happens over two passes - the first pass transforms Substrait relations to GoogleSQL scan ops, the second pass transforms Substrait plans (containing GoogleSQL ops) to pure GoogleSQL IR. This requires relaxing the region constraint such that the first pass can be successful.