-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add substrait.proto convenience module and document it #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
def _load(): | ||
"""Import all substrait protobuf classes as human friendly. | ||
|
||
Instead of forcing users to deal with autogenerated protobuf | ||
modules, importing individual components of the protocol | ||
from submodules etc... this functions loads into the module | ||
all classes representing substrait expressions and loads | ||
the protocol modules with a friendly name making the protocol | ||
more convenient to use. | ||
|
||
substrait.gen.proto.extensions.extensions_pb2.SimpleExtensionDeclaration | ||
becomes substrait.proto.SimpleExtensionDeclaration | ||
""" | ||
import sys | ||
import inspect | ||
import pkgutil | ||
import importlib | ||
from substrait.gen import proto as _proto | ||
|
||
selfmodule = sys.modules[__name__] | ||
for submodule_info in pkgutil.iter_modules(_proto.__path__): | ||
submodule_name = submodule_info.name | ||
attr_name = submodule_name.replace("_pb2", "") | ||
if submodule_name == "extensions": | ||
# Extensions are in a submodule | ||
submodule_name = "extensions.extensions_pb2" | ||
attr_name = "extensions" | ||
|
||
submodule = importlib.import_module(f".{submodule_name}", _proto.__name__) | ||
setattr(selfmodule, attr_name, submodule) | ||
|
||
for membername, _ in inspect.getmembers(submodule): | ||
member = getattr(submodule, membername) | ||
if inspect.isclass(member): | ||
setattr(selfmodule, membername, member) | ||
|
||
|
||
_load() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can go ahead and delete the
test_imports()
function above since the new test indirectly tests these imports.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a value in keeping this test to ensure backward compatibility.
substrait.proto
might continue to work but import the classes from modules with different names than the current ones.In such case we would be breaking backward compatibility for anyone directly accessing the classes from the
_pb2
modules and that's something we want to catch and be aware of.