feat: add builders for aggregate, window funcs and if-then #72
Conversation
tokoko
commented
Apr 12, 2025
tokoko
commented
- moves builders to a new directory
- renames FunctionRegistry to ExtensionRegistry
- adds new extended expression builders
src/substrait/builders/__init__.py
Outdated
There was a problem hiding this comment.
I think this file was deprecated in Python 3.3.
There was a problem hiding this comment.
done. I still bump into issues occasionally when init files are missing, but we can always add them if there's a need for it later
| output_type=func[1], | ||
| ) | ||
| ), | ||
| output_names=[alias if alias else "scalar_function"], |
There was a problem hiding this comment.
Should this be a unique name? Perhaps keep track of generated names and prepend a count for each reuse (and elsewhere).
There was a problem hiding this comment.
I switched to a rudimentary way of generating names from argument names. (ibis does something like this) Pretty sure it's gonna fail if the output type of an expression contains a struct, but it's a start. I'm not sure if it's worth it to infer an output type just to get the expected cardinality of the output_names array.
