refactor!: move code generation from build script to separate crate #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #412 to close #411.
This moves the build script to a separate
gencrate (outside the main workspace). It writes generated files tosrc/genof the main crate.This is a breaking change only because the
protocfeature is removed.This also adds a
generateworkflow to push updated generated files when we update the substrait submodule. With the dependabot update PRs it should make it easy to keep things updated. The other jobs will also run code generation, so for submodule updates the first commit checks with the updated generated files (because the bot push normally can't trigger other workflows).