Skip to content

feat: add names into struct type #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add names into struct type #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54ca4ad
feat: add names into struct type
Blizzara Apr 11, 2025
b6c80d6
feat: add names into struct literal
Blizzara Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion proto/substrait/algebra.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ message RelCommon {
// The scan operator of base data (physical or virtual), including filtering and projection.
message ReadRel {
RelCommon common = 1;
NamedStruct base_schema = 2;
Type.Struct base_schema = 2;
Copy link
Contributor Author

@Blizzara Blizzara Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be a breaking change, so I guess we can't do it. I'm just including it here for discussion - if we were to add names to the type itself, then we could replace (through some evolutions) the NamedStruct usages with Type.Struct.

Expression filter = 3;
Expression best_effort_filter = 11;
Expression.MaskExpression projection = 4;
Expand Down Expand Up @@ -1100,6 +1100,7 @@ message Expression {
message Struct {
// A possibly heterogeneously typed list of literals
repeated Literal fields = 1;
repeated string names = 4; // Optionally names for the fields in this struct. If provided, must match the length of "fields".
}

message List {
Expand Down
1 change: 1 addition & 0 deletions proto/substrait/type.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ message Type {

message Struct {
repeated Type types = 1;
repeated string names = 4; // Optionally names for the fields in this struct. If provided, must match the length of "types".
uint32 type_variation_reference = 2;
Nullability nullability = 3;
}
Expand Down
Loading