Handle non-JSON private HTTP errors#2615
Merged
Merged
Conversation
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #708
Private HTTP error handling now ignores JSON parse failures while trying to enrich
last_jsonfrom a failed response body. This preserves status-specific mapping such as 404 ->ClientNotFoundErrorinstead of leaking a JSON decode exception for HTML/non-JSON error pages.The regression is covered both in the hardening suite and in
PrivateGraphQLRequestRegressionTestCase, which is included in the GitHub Actions compatibility test subset.Verification:
.venv/bin/python -m pytest -q tests/regression/test_public.py::PrivateGraphQLRequestRegressionTestCase::test_send_private_request_ignores_non_json_body_on_http_error tests/regression/test_hardening.py::HardeningRegressionTestCase::test_send_private_request_ignores_non_json_body_on_http_error.venv/bin/python -m pytest -q tests/regression/test_public.py::PublicRegressionTestCase tests/regression/test_public.py::PrivateGraphQLRequestRegressionTestCase tests/regression/test_hardening.py tests/regression/test_request_logging.py.venv/bin/python -m pytest -q tests/regression.venv/bin/python -m ruff check ..venv/bin/python -m ruff format --check ..venv/bin/python -m bandit -c pyproject.toml -r instagrapi.venv/bin/python -m build