fix(operator): chunk header requests #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhtyy
force-pushed
the
n/chunk-header-requests
branch
from
8bb87dd to
5e8a04e
Compare
* chore: cleanup api / util seperation * chore: add retries to some tendermint routes * fix: dont need option on sleep duration * feat: multi-chain operator * log -> tracing * fix: cleanup * separate logs * feat: batch proofs * fix: log chain id on fail * temp: prints * cleanup * comments, default env filter * fix: use old env setup for one chain * update example env * Update script/src/util/retry.rs Co-authored-by: Ratan Kaliani <[email protected]> * fix: move consensus checks of target block to `run_inner` * Update script/bin/operator.rs Co-authored-by: Ratan Kaliani <[email protected]> * fix: remove `we` from comments * fix: new fn for vkey/data commit max checks * add section headings in operator, use_kms -> signer mode * missed `we` * fix: use_kms_relayer -> signer_mode * run -> loop Co-authored-by: Ratan Kaliani <[email protected]> * Revert "run -> loop" This reverts commit c4eacbf. * chore: simplify operator loop, renaming, better comments (#50) * chore: help refactor * add * add * chore: arc networkprover * chore: docs * docs * chore: fmt * rm unused clones & arc --------- Co-authored-by: Ratan Kaliani <[email protected]>
nhtyy
force-pushed
the
n/chunk-header-requests
branch
from
8aa9529 to
9e6dad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "chunking" to the "header range requests" and a sleep in between chunks, as we now need to work around ratelimiting.
This PR also removes an unused function.
The general strategy is that it always tries concurrently fetch the chunks, however, if it encounters a partial failure (ie. half the chunk is an err due to rate limiting), it will save all the
Ok(_)results and sleep (with exponential backoff).It also removes unwraps and uses anyhow Error in place.
Also to note: It will sleep for a shorter time if an error is returned from
run