fix: enforce one-hot operation flags in BaseAlu eval #2512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
We only checked the Boolean value of the sum of the operation flags (is_add + is_sub + is_mul + is_div), rather than each flag individually. This allowed the prover to set a non-strict one-hot set of flags: for example, to make is_add = a, is_sub = 1 - a when is_real = 1, that is, to activate two flags at once in a linear combination, which violates the semantics of “exactly one operation performed” and could simultaneously attach several when(...) constraints on the same in1/in2/out.
The solution:
Explicitly assert the Boolean value of each flag and separately check that the sum of the flags is Boolean. As a result, in a real string, exactly one flag is equal to 1, while in padding, all flags are equal to 0; the behavior now corresponds to the intended one-hot logic.