-
Notifications
You must be signed in to change notification settings - Fork 605
recursion: add R1CS dump/shrink tooling #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sidhujag
wants to merge
181
commits into
succinctlabs:dev
Choose a base branch
from
syscoin:dump-r1cs
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phase 0 explicitly exports only RecursionPublicValues.digest as public inputs (see phase0_collect_public_ids around lines 260–272), but CircuitV2CommitPublicValues asserts that sp1_vk_digest (and later committed_value_digest) must occupy the public-input prefix. In BabyBear recursion circuits those fields are not preallocated, so debug builds will panic when compiling the shrink verifier (e.g., dump_shrink_verify_constraints in debug), and release builds will silently accept a public-input layout that contradicts these checks. Consider validating the digest IDs here instead, or expand Phase 0 to include the other fields if they are meant to be public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds utilities and plumbing to dump, shrink, and verify recursion/R1CS constraints for SP1 programs, plus supporting updates across the recursion toolchain and gnark-ffi.
Changes
dump_shrink_verify_constraintsprover binary and related helpers.Test plan
cargo test -p prover -p recursion-compiler -p recursion-circuit -p verifiercargo run -p prover --bin dump_shrink_verify_constraints -- --helpand a representative program config.crates/recursion/gnark-ffi/go/.Notes