feat(sdk): add proof deserialization from bytes#2821
Open
peter941221 wants to merge 1 commit into
Open
Conversation
peter941221
force-pushed
the
peter/issue-2521-proof-from-bytes
branch
from
ea9ce7c to
29d215d
Compare
peter941221
force-pushed
the
peter/issue-2521-proof-from-bytes
branch
from
29d215d to
80b9ffb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2521
Failure mechanism
SP1ProofWithPublicValues supported file-based save -> load, but did not expose a direct byte-slice deserialization entrypoint even though callers may already have the serialized proof bytes in memory.
Semantic change
Add SP1ProofWithPublicValues::from_bytes(&[u8]), preserve fallback compatibility with ProofFromNetwork, and make load(path) reuse the same byte-based decode path.
Preserved invariants
The proof struct layout is unchanged. Existing file-based loading behavior is preserved, including the fallback path for serialized ProofFromNetwork values that do not carry tee_proof.
Testing
cargo +nightly fmt --all
Added focused unit coverage for round-trip byte decoding and ProofFromNetwork fallback decoding.
Full local cargo check/test on this Windows machine is still blocked upstream by a missing protoc binary for sp1-prover-types and by Unix-only sp1-jit imports in crates/core/jit.