fix: handle patch-testing comment runs without PR context#2842
Draft
peter941221 wants to merge 1 commit into
Draft
fix: handle patch-testing comment runs without PR context#2842peter941221 wants to merge 1 commit into
peter941221 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Patch Testing Cycles Comment runs that do not have a PR attached in the workflow_run payload.
The failure showed up in run 27173224829. GitHub returned pull_requests: [] for that run, but the workflow still tried to read .pull_requests[0].number and passed the result into post-to-github. The posting binary then unwrapped PR_NUMBER and panicked while decoding the GitHub comments response.
This change adds the guard in both places that assume PR context:
The benchmark comparison path stays the same. If the run has a real PR, the workflow still posts the generated comparison comment through the existing code path.
Testing: