Add pwfeedback_char option to allow configuring the feedback character#532
Open
halleyscommet wants to merge 1 commit intosudo-project:mainfrom
Open
Add pwfeedback_char option to allow configuring the feedback character#532halleyscommet wants to merge 1 commit intosudo-project:mainfrom
halleyscommet wants to merge 1 commit intosudo-project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when pwfeedback is enabled in sudoers, the feedback character
is hardcoded to '*' in tgetpass.c. This adds a new sudoers option,
pwfeedback_char, that allows administrators to configure the character
used for password feedback.
Example usage in sudoers:
Defaults pwfeedback
Defaults pwfeedback_char="•"
The default value remains '*' so existing behavior is unchanged.
Input validation rejects empty strings and values longer than 4 bytes
(the maximum size of a UTF-8 character).
Note: lib/util/util.map also requires the following line added under
the sudo_term_* entries to export the new symbol, but this file is
listed in .gitignore and could not be included in this PR:
sudo_pwfeedback_char;