CS-4064: Refresh Token in IDM enabled Instance does not live more tha…#115
Open
odukhnytskyi-sugarcrm wants to merge 1 commit intosugarcrm:masterfrom
Open
CS-4064: Refresh Token in IDM enabled Instance does not live more tha…#115odukhnytskyi-sugarcrm wants to merge 1 commit intosugarcrm:masterfrom
odukhnytskyi-sugarcrm wants to merge 1 commit intosugarcrm:masterfrom
Conversation
src/client.js
Outdated
| // prevents concurrent events from multiple tabs asking for a | ||
| // refresh token | ||
| if (_refreshingToken) { | ||
| return; |
Collaborator
There was a problem hiding this comment.
Can you please describe how it works?
Value of a variable is not sharing between browser tabs, so _refreshingToken is always undefined here, isn't it?
Contributor
Author
There was a problem hiding this comment.
I think so. We don't use crosstab functionality correctly here. We send refresh token simultaneously for different tabs in this place. For regular behaviour, we consider refresh token process could already be run and doesn't allow sending request from different tab. here: https://github.com/sugarcrm/ventana/blob/master/src/client.js#L2146
But in case _handleErrorAndRefreshToken method is called we don't provide the same logic
eyushchyk-sugarcrm
requested changes
Oct 28, 2024
odukhnytskyi-sugarcrm
force-pushed
the
CS-4064
branch
7 times, most recently
from
884a45e to
d388c07
Compare
odukhnytskyi-sugarcrm
force-pushed
the
CS-4064
branch
from
d388c07 to
93e27c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n 24 hours