Added Notification timeout to widgets (#4256)

justin212407 · web-flow · commit cb90f9286173 · 2025-01-11T16:12:20.000-05:00
Signed-off-by: Justin Charles &lt;charlesjustin2124@gmail.com&gt;
diff --git a/js/widgets/arpeggio.js b/js/widgets/arpeggio.js
@@ -236,7 +236,7 @@ class Arpeggio {
         };
 
         this.makeClickable();
-        this._activity.textMsg(_("Click in the grid to add steps to the arpeggio."));
+        activity.textMsg(_("Click in the grid to add steps to the arpeggio."), 3000);
     }
 
     /**
diff --git a/js/widgets/meterwidget.js b/js/widgets/meterwidget.js
@@ -298,7 +298,7 @@ class MeterWidget {
             this.activity.logo.runLogoCommands(widgetBlock);
         };
 
-        this.activity.textMsg(_("Click in the circle to select strong beats for the meter."));
+        activity.textMsg(_("Click in the circle to select strong beats for the meter."), 3000);
         widgetWindow.sendToCenter();
         this._scale.call(this.widgetWindow);
     }
diff --git a/js/widgets/modewidget.js b/js/widgets/modewidget.js
@@ -160,7 +160,7 @@ class ModeWidget {
         this._setMode();
 
         //.TRANS: A circle of notes represents the musical mode.
-        this.activity.textMsg(_("Click in the circle to select notes for the mode."));
+        activity.textMsg(_("Click in the circle to select notes for the mode."), 3000);
         setTimeout(this.widgetWindow.sendToCenter, 0);
     }
 
@@ -1014,7 +1014,7 @@ class ModeWidget {
         // Create a new stack for the chunk.
         // console.debug(newStack);
         this.activity.blocks.loadNewBlocks(newStack);
-        this.activity.textMsg(_("New action block generated."));
+        activity.textMsg(_("New action block generated."), 3000);
 
         // And save a stack of pitchnumbers to be used with the define mode
         newStack = [
diff --git a/js/widgets/musickeyboard.js b/js/widgets/musickeyboard.js
@@ -3210,8 +3210,8 @@ function MusicKeyboard(activity) {
             this.activity.blocks.loadNewBlocks(newStack);
         }
 
-        if (actionGroups > 1) this.activity.textMsg(_("New action blocks generated."));
-        else this.activity.textMsg(_("New action block generated."));
+        if (actionGroups > 1) activity.textMsg(_("New action blocks generated."), 3000);
+        else activity.textMsg(_("New action block generated."), 3000);
     };
 
     /**
@@ -3396,18 +3396,18 @@ function MusicKeyboard(activity) {
             // re-init widget
             if (this.midiON) {
                 this.midiButton.style.background = "#00FF00";
-                this.activity.textMsg(_("MIDI device present."));
+                activity.textMsg(_("MIDI device present."), 3000);
                 return;
             }
             midiAccess.inputs.forEach((input) => {
                 input.onmidimessage = onMIDIMessage;
             });
             if (midiAccess.inputs.size) {
                 this.midiButton.style.background = "#00FF00";
-                this.activity.textMsg(_("MIDI device present."));
+                activity.textMsg(_("MIDI device present."), 3000);
                 this.midiON = true;
             } else {
-                this.activity.textMsg(_("No MIDI device found."));
+                activity.textMsg(_("No MIDI device found."), 3000);
             }
         };
 
@@ -3417,7 +3417,7 @@ function MusicKeyboard(activity) {
          * @memberof ClassName
          */
         const onMIDIFailure = () => {
-            this.activity.errorMsg(_("Failed to get MIDI access in browser."));
+            activity.errorMsg(_("Failed to get MIDI access in browser."), 3000);
             this.midiON = false;
         };
 
diff --git a/js/widgets/phrasemaker.js b/js/widgets/phrasemaker.js
@@ -1072,7 +1072,7 @@ class PhraseMaker {
         }
 
         if (this.isInitial) {
-            this.activity.textMsg(_("Click on the table to add notes."));
+            activity.textMsg(_("Click on the table to add notes."), 3000);
             this.widgetWindow.sendToCenter();
             this.inInitial = false;
         }
@@ -4613,7 +4613,7 @@ class PhraseMaker {
     __playNote(time, noteCounter) {
         // Show lyrics while playing notes.
         if (this.lyricsON) {
-            this.activity.textMsg(this._lyrics[noteCounter]);
+            activity.textMsg(this._lyrics[noteCounter], 3000);
         }
         // If the widget is closed, stop playing.
         if (!this.widgetWindow.isVisible()) {
@@ -5499,6 +5499,6 @@ class PhraseMaker {
 
         // Create a new stack for the chunk.
         this.activity.blocks.loadNewBlocks(newStack);
-        this.activity.textMsg(_("New action block generated."));
+        activity.textMsg(_("New action block generated."), 3000 );
     }
 }
diff --git a/js/widgets/pitchdrummatrix.js b/js/widgets/pitchdrummatrix.js
@@ -353,7 +353,7 @@ class PitchDrumMatrix {
             }
         };
 
-        this.activity.textMsg(_("Click in the grid to map notes to drums."));
+        activity.textMsg(_("Click in the grid to map notes to drums."), 3000);
     }
 
     /**
@@ -749,7 +749,7 @@ class PitchDrumMatrix {
             }, pairs.length * 1000);
         } else {
             if (!this.widgetWindow._maximized) {
-                this.activity.textMsg(_("Click in the grid to map notes to drums."));
+                activity.textMsg(_("Click in the grid to map notes to drums."), 3000);
             }
             icon.innerHTML =
                 '&nbsp;&nbsp;<img src="header-icons/' +
diff --git a/js/widgets/pitchslider.js b/js/widgets/pitchslider.js
@@ -133,7 +133,7 @@ class PitchSlider {
             MakeToolbar(id);
         }
 
-        this.activity.textMsg(_("Click on the slider to create a note block."));
+        activity.textMsg(_("Click on the slider to create a note block."), 3000);
         setTimeout(this.widgetWindow.sendToCenter, 0);
     }
 
diff --git a/js/widgets/pitchstaircase.js b/js/widgets/pitchstaircase.js
@@ -577,7 +577,7 @@ class PitchStaircase {
         }
 
         this.activity.blocks.loadNewBlocks(newStack);
-        this.activity.textMsg(_("New action block generated."));
+        activity.textMsg(_("New action block generated."), 3000);
     }
 
     /**
@@ -693,7 +693,7 @@ class PitchStaircase {
         widgetWindow.getWidgetBody().append(this._pscTable);
         this._refresh();
 
-        this.activity.textMsg(_("Click on a note to create a new step."));
+        activity.textMsg(_("Click on a note to create a new step."), 3000);
 
         widgetWindow.onmaximize = () => {
             if (widgetWindow._maximized) {
diff --git a/js/widgets/rhythmruler.js b/js/widgets/rhythmruler.js
@@ -814,7 +814,7 @@ class RhythmRuler {
             }
         }
 
-        this.activity.textMsg(_("Click on the ruler to divide it."));
+        activity.textMsg(_("Click on the ruler to divide it."), 3000);
         // this._piemenuRuler(this._rulerSelected);
     }
 
@@ -2251,7 +2251,7 @@ class RhythmRuler {
         }
 
         this.activity.blocks.loadNewBlocks(newStack);
-        this.activity.textMsg(_("New action block generated."));
+        activity.textMsg(_("New action block generated."), 3000);
     }
 
     /**
@@ -2469,7 +2469,7 @@ class RhythmRuler {
             }
 
             this.activity.blocks.loadNewBlocks(newStack);
-            this.activity.textMsg(_("New action block generated."));
+            activity.textMsg(_("New action block generated."), 3000);
             if (selectedRuler > this.Rulers.length - 2) {
                 return;
             } else {
diff --git a/js/widgets/sampler.js b/js/widgets/sampler.js
@@ -234,15 +234,15 @@ function SampleWidget() {
      * @returns {void}
      */
     this.displayRecordingStartMessage = function () {
-        this.activity.textMsg(_("Recording started"));
+        activity.textMsg(_("Recording started"), 3000);
     }
 
     /**
      * Displays a message indicating that recording has stopped.
      * @returns {void}
      */
     this.displayRecordingStopMessage = function () {
-        this.activity.textMsg(_("Recording complete"));
+        activity.textMsg(_("Recording complete"), 3000);
     }
 
 
@@ -280,7 +280,7 @@ function SampleWidget() {
             ];
 
             that.activity.blocks.loadNewBlocks(newStack);
-            that.activity.textMsg(_("A new sample block was generated."));
+            activity.textMsg(_("A new sample block was generated."), 3000);
         }, 1000);
     };
 
@@ -500,7 +500,7 @@ function SampleWidget() {
 
         this.setTimbre();
 
-        this.activity.textMsg(_("Upload a sample and adjust its pitch center."));
+        activity.textMsg(_("Upload a sample and adjust its pitch center."), 3000);
         this.pause();
 
         widgetWindow.sendToCenter();
diff --git a/js/widgets/temperament.js b/js/widgets/temperament.js
@@ -926,7 +926,7 @@ function TemperamentWidget() {
             try{
                 that.performEqualEdit(event);
             } catch{
-                this.activity.errorMsg(_("The Number of divisions is too large."));
+                activity.errorMsg(_("The Number of divisions is too large."), 3000);
             }
 
         });
@@ -1613,7 +1613,7 @@ function TemperamentWidget() {
             const ratio = startRatio / endRatio;
             if (ratio !== 2) {
                 that.activity.textMsg(
-                    _("The octave ratio has changed. This changes temperament significantly.")
+                    _("The octave ratio has changed. This changes temperament significantly."), 3000
                 );
             }
             const powers = [];
@@ -1926,7 +1926,7 @@ function TemperamentWidget() {
         const that = this;
         setTimeout(() => {
             that.activity.blocks.loadNewBlocks(newStack);
-            that.activity.textMsg(_("New action block generated."));
+            activity.textMsg(_("New action block generated."), 3000);
         }, 500);
 
         if (isCustomTemperament(this.inTemperament)) {
diff --git a/js/widgets/tempo.js b/js/widgets/tempo.js
@@ -191,7 +191,7 @@ class Tempo {
             );
         }
 
-        this.activity.textMsg(_("Adjust the tempo with the buttons."));
+        activity.textMsg(_("Adjust the tempo with the buttons."),3000);
         this.resume();
 
         widgetWindow.sendToCenter();
@@ -258,17 +258,17 @@ class Tempo {
         const input = this.BPMInputs[i].value;
 
         if (isNaN(input)) {
-            this.activity.errorMsg(_("Please enter a number between 30 and 1000"));
+            activity.errorMsg(_("Please enter a number between 30 and 1000"), 3000);
             return;
         }
         
         this.BPMs[i] = this.BPMInputs[i].value;
         if (this.BPMs[i] > 1000) {
             this.BPMs[i] = 1000;
-            this.activity.errorMsg(_("The beats per minute must be between 30 and 1000."));
+            activity.errorMsg(_("The beats per minute must be between 30 and 1000."), 3000);
         } else if (this.BPMs[i] < 30) {
             this.BPMs[i] = 30;
-            this.activity.errorMsg(_("The beats per minute must be between 30 and 1000."));
+            activity.errorMsg(_("The beats per minute must be between 30 and 1000."), 3000);
         }
 
         this._updateBPM(i);
@@ -284,7 +284,7 @@ class Tempo {
         this.BPMs[i] = parseFloat(this.BPMs[i]) + Math.round(0.1 * this.BPMs[i]);
 
         if (this.BPMs[i] > 1000) {
-            this.activity.errorMsg(_("The beats per minute must be below 1000."));
+            activity.errorMsg(_("The beats per minute must be below 1000."), 3000);
             this.BPMs[i] = 1000;
         }
 
@@ -300,7 +300,7 @@ class Tempo {
     slowDown(i) {
         this.BPMs[i] = parseFloat(this.BPMs[i]) - Math.round(0.1 * this.BPMs[i]);
         if (this.BPMs[i] < 30) {
-            this.activity.errorMsg(_("The beats per minute must be above 30"));
+            activity.errorMsg(_("The beats per minute must be above 30"), 3000);
             this.BPMs[i] = 30;
         }
 
@@ -411,7 +411,7 @@ class Tempo {
                 [5, ["vspace", {}], 0, 0, [0, null]]
             ];
             this.activity.blocks.loadNewBlocks(newStack);
-            this.activity.textMsg(_("New action block generated."));
+            activity.textMsg(_("New action block generated."), 3000);
         }, 200 * i);
     }
 
diff --git a/js/widgets/timbre.js b/js/widgets/timbre.js
@@ -779,7 +779,7 @@ class TimbreWidget {
             if (this.osc.length === 0) {
                 this._synth();
             } else {
-                this.activity.errorMsg(_("Unable to use synth due to existing oscillator"));
+                activity.errorMsg(_("Unable to use synth due to existing oscillator"), 3000);
             }
         };
 
@@ -984,7 +984,7 @@ class TimbreWidget {
             filterButtonCell.style.backgroundColor = platformColor.selectorBackground;
         };
 
-        this.activity.textMsg(_("Click on buttons to open the timbre design tools."));
+        activity.textMsg(_("Click on buttons to open the timbre design tools."), 3000);
         widgetWindow.sendToCenter();
     }
 
@@ -1916,7 +1916,7 @@ class TimbreWidget {
                 (el) => el.filterType === elem.value
             );
             if (error.length > 1) {
-                this.activity.errorMsg(_("Filter already present."));
+                activity.errorMsg(_("Filter already present."), 3000);
             }
             this._playNote("G4", 1 / 8);
         };

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ class Arpeggio {`
`236`	`236`	`};`
`237`	`237`
`238`	`238`	`this.makeClickable();`
`239`		`- this._activity.textMsg(_("Click in the grid to add steps to the arpeggio."));`
	`239`	`+ activity.textMsg(_("Click in the grid to add steps to the arpeggio."), 3000);`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ class MeterWidget {`
`298`	`298`	`this.activity.logo.runLogoCommands(widgetBlock);`
`299`	`299`	`};`
`300`	`300`
`301`		`- this.activity.textMsg(_("Click in the circle to select strong beats for the meter."));`
	`301`	`+ activity.textMsg(_("Click in the circle to select strong beats for the meter."), 3000);`
`302`	`302`	`widgetWindow.sendToCenter();`
`303`	`303`	`this._scale.call(this.widgetWindow);`
`304`	`304`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1072,7 +1072,7 @@ class PhraseMaker {`
`1072`	`1072`	`}`
`1073`	`1073`
`1074`	`1074`	`if (this.isInitial) {`
`1075`		`- this.activity.textMsg(_("Click on the table to add notes."));`
	`1075`	`+ activity.textMsg(_("Click on the table to add notes."), 3000);`
`1076`	`1076`	`this.widgetWindow.sendToCenter();`
`1077`	`1077`	`this.inInitial = false;`
`1078`	`1078`	`}`
`@@ -4613,7 +4613,7 @@ class PhraseMaker {`
`4613`	`4613`	`__playNote(time, noteCounter) {`
`4614`	`4614`	`// Show lyrics while playing notes.`
`4615`	`4615`	`if (this.lyricsON) {`
`4616`		`- this.activity.textMsg(this._lyrics[noteCounter]);`
	`4616`	`+ activity.textMsg(this._lyrics[noteCounter], 3000);`
`4617`	`4617`	`}`
`4618`	`4618`	`// If the widget is closed, stop playing.`
`4619`	`4619`	`if (!this.widgetWindow.isVisible()) {`
`@@ -5499,6 +5499,6 @@ class PhraseMaker {`
`5499`	`5499`
`5500`	`5500`	`// Create a new stack for the chunk.`
`5501`	`5501`	`this.activity.blocks.loadNewBlocks(newStack);`
`5502`		`- this.activity.textMsg(_("New action block generated."));`
	`5502`	`+ activity.textMsg(_("New action block generated."), 3000 );`
`5503`	`5503`	`}`
`5504`	`5504`	`}`
Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,7 @@ class PitchDrumMatrix {`
`353`	`353`	`}`
`354`	`354`	`};`
`355`	`355`
`356`		`- this.activity.textMsg(_("Click in the grid to map notes to drums."));`
	`356`	`+ activity.textMsg(_("Click in the grid to map notes to drums."), 3000);`
`357`	`357`	`}`
`358`	`358`
`359`	`359`	`/**`
`@@ -749,7 +749,7 @@ class PitchDrumMatrix {`
`749`	`749`	`}, pairs.length * 1000);`
`750`	`750`	`} else {`
`751`	`751`	`if (!this.widgetWindow._maximized) {`
`752`		`- this.activity.textMsg(_("Click in the grid to map notes to drums."));`
	`752`	`+ activity.textMsg(_("Click in the grid to map notes to drums."), 3000);`
`753`	`753`	`}`
`754`	`754`	`icon.innerHTML =`
`755`	`755`	`'  <img src="header-icons/' +`
Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ class PitchSlider {`
`133`	`133`	`MakeToolbar(id);`
`134`	`134`	`}`
`135`	`135`
`136`		`- this.activity.textMsg(_("Click on the slider to create a note block."));`
	`136`	`+ activity.textMsg(_("Click on the slider to create a note block."), 3000);`
`137`	`137`	`setTimeout(this.widgetWindow.sendToCenter, 0);`
`138`	`138`	`}`
`139`	`139`
Original file line number	Diff line number	Diff line change
`@@ -577,7 +577,7 @@ class PitchStaircase {`
`577`	`577`	`}`
`578`	`578`
`579`	`579`	`this.activity.blocks.loadNewBlocks(newStack);`
`580`		`- this.activity.textMsg(_("New action block generated."));`
	`580`	`+ activity.textMsg(_("New action block generated."), 3000);`
`581`	`581`	`}`
`582`	`582`
`583`	`583`	`/**`
`@@ -693,7 +693,7 @@ class PitchStaircase {`
`693`	`693`	`widgetWindow.getWidgetBody().append(this._pscTable);`
`694`	`694`	`this._refresh();`
`695`	`695`
`696`		`- this.activity.textMsg(_("Click on a note to create a new step."));`
	`696`	`+ activity.textMsg(_("Click on a note to create a new step."), 3000);`
`697`	`697`
`698`	`698`	`widgetWindow.onmaximize = () => {`
`699`	`699`	`if (widgetWindow._maximized) {`
Original file line number	Diff line number	Diff line change
`@@ -814,7 +814,7 @@ class RhythmRuler {`
`814`	`814`	`}`
`815`	`815`	`}`
`816`	`816`
`817`		`- this.activity.textMsg(_("Click on the ruler to divide it."));`
	`817`	`+ activity.textMsg(_("Click on the ruler to divide it."), 3000);`
`818`	`818`	`// this._piemenuRuler(this._rulerSelected);`
`819`	`819`	`}`
`820`	`820`
`@@ -2251,7 +2251,7 @@ class RhythmRuler {`
`2251`	`2251`	`}`
`2252`	`2252`
`2253`	`2253`	`this.activity.blocks.loadNewBlocks(newStack);`
`2254`		`- this.activity.textMsg(_("New action block generated."));`
	`2254`	`+ activity.textMsg(_("New action block generated."), 3000);`
`2255`	`2255`	`}`
`2256`	`2256`
`2257`	`2257`	`/**`
`@@ -2469,7 +2469,7 @@ class RhythmRuler {`
`2469`	`2469`	`}`
`2470`	`2470`
`2471`	`2471`	`this.activity.blocks.loadNewBlocks(newStack);`
`2472`		`- this.activity.textMsg(_("New action block generated."));`
	`2472`	`+ activity.textMsg(_("New action block generated."), 3000);`
`2473`	`2473`	`if (selectedRuler > this.Rulers.length - 2) {`
`2474`	`2474`	`return;`
`2475`	`2475`	`} else {`