fix: simultaneous opening of Pitch Pie Menu and Grey Menu on Right Click

[haroon10725]

I found that this.container has both an on-click and a press-up event listener:
The on-click listener checks if the Ctrl key is pressed. If it is, it triggers the piemenuBlockContext function, which displays a grey menu. After this, the function returns, preventing any further code from executing.
The press-up listener calls the _mouseoutCallback function, but only if that.blocks.getLongPressStatus is false. This ultimately triggers the _changeLabels function without checking whether the Ctrl key is pressed or not.

@walterbender Can you please review it ?

[walterbender]

Can you please link to the issue you are fixing? Does it describe how to reproduce the issue?
I don't recall the ctrl key being mentioned.

[haroon10725]

#3986

[walterbender]

Thanks. I don't have a Mac, so I cannot test it. I presume you did?

[haroon10725]

@walterbender Yes, I did. I think you can also reproduce the same error by doing ctrl + click on a block.

[walterbender]

If you control-click on the background, you don't get the large menu. Is that OK? Long press works on a block, but not on the background. Is that OK?

I think a better solution would be to determine where the click is occurring.

[haroon10725]

No, I get large menu.

[walterbender]

Hmm. The only way I can get the large menu on my machine (Fedora) is a right-click.

[haroon10725]

@walterbender Were you able to reproduce it ( ctrl + click on a block and both menu's appear ) ?

[walterbender]

I cannot reproduce the bug as stated in the ticket using ctrl, but I can do this:

I'll try this with your branch. But I suspect that we need to think this through more.

[haroon10725]

I am pressing ctrl + click ( using touchpad ). Maybe try this. I have tested on Windows and Mac, works fine.

[haroon10725]

I cannot reproduce the bug as stated in the ticket using ctrl, but I can do this:

I'll try this with your branch. But I suspect that we need to think this through more.

How were you able to do it ?

[walterbender]

There are 4 different mechanisms at play across 5 conditions:

Mechanisms:
click
right click
ctrl click
long press

Conditions:
background
normal block
collapsible block (on collapse button)
block that opens a pie menu
number or text block

We want the following priority:

1. pie menu for block value
2. input form for block value
3. collapse/expand block
4. block context menu (small gray pie menu)
5. large gray menu

1 and 2 can co-exist.
Otherwise, the higher priority should be used.

In the current implementation, sometimes multiple conditions are triggered.

[haroon10725]

I couldn't fully understand what you say.

[walterbender]

Any progress on this?

[haroon10725]

@walterbender I am identifying in the code where each of the events are being triggered.

[github-actions]

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

[haroon10725]

I am working on it, got busy due to my exams.

[haroon10725]

@walterbender Should I close this PR? I couldn't test it as I have changed my OS.
I faced the issue on Mac OS. Not sure whether it has been fixed or not.

[walterbender]

I think this is sorted out but there are still some separate issues with touch.

[haroon10725]

I think this is sorted out but there are still some separate issues with touch.

@walterbender I will look at those.

[walterbender]

@haroon10725 Look at #4213