Skip to content

Disabled record and save buttons while music is playing #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
walterbender merged 2 commits into from
Jan 10, 2025
Merged

Disabled record and save buttons while music is playing #4245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd9244e
Disabled record and save buttons while music is playing
falgun143 Jan 8, 2025
24988bc
removed extra lines
falgun143 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/artwork.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions js/logo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1792,6 +1792,14 @@ class Logo {
}
}
document.getElementById("stop").style.color = "white";
const saveButton = docById('saveButton');
const saveButtonAdvanced = docById('saveButtonAdvanced');
const recordButton = docById("record");
saveButton.disabled = false;
saveButtonAdvanced.disabled = false;
saveButton.className = "";
saveButtonAdvanced.className = "";
recordButton.className = "";
}
}
}
Expand Down
13 changes: 12 additions & 1 deletion js/toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ class Toolbar {
renderPlayIcon(onclick) {
const playIcon = docById("play");
const stopIcon = docById("stop");

const recordButton = docById("record");
let isPlayIconRunning = false;

function handleClick() {
Expand All @@ -378,6 +378,11 @@ class Toolbar {
onclick(this.activity);
handleClick();
stopIcon.style.color = this.stopIconColorWhenPlaying;
saveButton.disabled = true;
saveButtonAdvanced.disabled = true;
saveButton.className = "grey-text inactiveLink";
saveButtonAdvanced.className = "grey-text inactiveLink";
recordButton.className = "grey-text inactiveLink";
isPlayIconRunning = true;
play_button_debounce_timeout = setTimeout(function() { handleClick(); }, 2000);

Expand All @@ -399,9 +404,15 @@ class Toolbar {
*/
renderStopIcon(onclick) {
const stopIcon = docById("stop");
const recordButton = docById("record");
stopIcon.onclick = () => {
onclick(this.activity);
stopIcon.style.color = "white";
saveButton.disabled = false;
saveButtonAdvanced.disabled = false;
saveButton.className = "";
saveButtonAdvanced.className = "";
recordButton.className = "";
};
}

Expand Down
Loading