Disable icon (save & record button)#4250
Closed
Commanderk3 wants to merge 5 commits intosugarlabs:masterfrom
Closed
Disable icon (save & record button)#4250Commanderk3 wants to merge 5 commits intosugarlabs:masterfrom
Commanderk3 wants to merge 5 commits intosugarlabs:masterfrom
Conversation
Contributor
|
You're welcome! I think you have not added the disabling of record button, that fix we also need |
Member
Author
Yes, I will do it. |
Member
Author
|
Now record is also disabled when clicked between the playing session. If clicked before then it will start recording and cannot turn it back off when "Play" is clicked until the user stops it or the session ends. fix-icon.webm |
Commanderk3
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the issue (#4239) of being able to click save icon while playing MB. Also thanks to @BeNikk and @falgun143. There work made this PR possible, and I was able to know what was the problem.
The disabling of icon works similar to disabling of pallets and blocks when "play" is clicked.
@walterbender Please check this PR.