Stop loading text in background#4283
Merged
walterbender merged 3 commits intosugarlabs:masterfrom Jan 18, 2025
Merged
Conversation
Member
|
Maybe we need to adjust some of the timeouts? The third string is never shown. |
index.html
Outdated
| // Stop changing text and finalize loading after 6 seconds | ||
| setTimeout(function () { | ||
| clearInterval(intervalId); | ||
| loadingText.textContent = "Loading Complete!"; |
Member
There was a problem hiding this comment.
Doesn't this need _() too?
Member
Author
There was a problem hiding this comment.
Oh yes, i will update
Member
Author
|
@walterbender Sir this should fix the issue. |
Ubayed-Bin-Sufian
pushed a commit
to Ubayed-Bin-Sufian/musicblocks
that referenced
this pull request
Jan 24, 2025
* stop message * translation added * fix2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading text message function runs in the background
@walterbender I noticed that the loading messages continued to change even after the loading screen was dismissed. This PR addresses the issue, ensuring smoother behavior and making Music Blocks slightly more efficient.
load.fix.mp4