Fix: docByID undefined#4294
Closed
FirePheonix wants to merge 2 commits intosugarlabs:masterfrom
FirePheonix:docByIdUndefined
Closed
Fix: docByID undefined#4294FirePheonix wants to merge 2 commits intosugarlabs:masterfrom FirePheonix:docByIdUndefined
FirePheonix wants to merge 2 commits intosugarlabs:masterfrom
FirePheonix:docByIdUndefined
Conversation
FirePheonix
changed the title
Member
|
Wouldn't it be better to fix the race condition? |
Contributor
Author
|
yep. that's right. i'm working on it. |
Contributor
|
I think this race condition can be solved by ensuring utils.js file (in which docById is defined) is loaded before activity.js, has to be a small fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #4293
I simply commented out the console.error . Made sure that the functionality works and we weren't in ANY race conditions because of this one.
and yes, the docByID undefined error occured due to code containing the docByID function not being loaded before it being called during initialization.