Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pie menu with functional number and action buttons #4309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sahilkkc01
Copy link
Contributor

@sahilkkc01 sahilkkc01 commented Jan 26, 2025

Changes Made
Immprovements from Pie menu for Rhythm Maker #4273 .

  • Added a circular pie menu for selecting numbers.
  • Included +, -, and X action buttons.
  • Enabled dynamic positioning and click-outside-to-close.

piemenuNumber() is specific to the Block class, as it relies on properties that RhythmRuler class lacks and doesn't work for RhythmRuler, so implemented a separate approach.

Beginner
Advanced

@sahilkkc01
Copy link
Contributor Author

@pikurasa Can you please review this

@walterbender
Copy link
Member

It works well. I am not sure that the color scheme is in keeping with the rest of the interface. I am also on the fence about creating a separate mechanism for generating pie menus. Could we not add a generic numbers menu to piemenu.js so that it is using the same mechanism as everywhere else?

@sahilkkc01
Copy link
Contributor Author

@walterbender I'll explore adding a generic numbers menu to piemenu.js for consistency and will also review the color scheme to ensure better UI integration.

@pikurasa
Copy link
Collaborator

I agree with Walter that we need to keep things consistent with the rest of the interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants