Skip to content

Enhance help widget#4364

Merged
walterbender merged 8 commits intosugarlabs:masterfrom
Ubayed-Bin-Sufian:improve_help_widget
Feb 13, 2025
Merged

Enhance help widget#4364
walterbender merged 8 commits intosugarlabs:masterfrom
Ubayed-Bin-Sufian:improve_help_widget

Conversation

@Ubayed-Bin-Sufian
Copy link
Contributor

@Ubayed-Bin-Sufian Ubayed-Bin-Sufian commented Feb 7, 2025

Summary

This PR improves the readability of the help widget.

Changes introduced:

  1. Added the Record context in Advanced Mode.

  2. Reordered the context based on Beginner and Advanced Mode for better organization.

  3. Updated the order of elements:

    • Main Toolbar
    • Auxiliary Toolbar
    • Right-Click Contextual Block & Canvas Menu
    • Palettes
  4. Added missing options:

    • Change Theme
    • Merge with Current Project
    • Load Plugin
    • Set Pitch Preview
    • Contextual Menu for Blocks
    • Contextual Menu for Canvas
    • Select
  5. Refined content for:

    • Save (Advanced Mode)
    • Help
    • Grid
  6. Updated color from #ffffff (white) to #292929 with 0.4 opacity to better match the Music Blocks theme.

Screenshots/video

Before

Screenshare.-.2025-02-11.12_37_02.AM.mp4

After

Screenshare.-.2025-02-11.12_40_01.AM.mp4

Checklist:

  • My changes adhere to the project's contribution guidelines.
  • Code changes have been implemented and tested.

@walterbender
Copy link
Member

I don't quite get the new ordering. The record button seems out of place.
In general, I think the help content needs an overhaul. For example, the save menu descriptions are redundant. The grid menu is incomplete. The right click menu probably needs its own slide. et al.

@Ubayed-Bin-Sufian Ubayed-Bin-Sufian force-pushed the improve_help_widget branch 3 times, most recently from f8cdd9b to 509b5af Compare February 10, 2025 06:56
@Ubayed-Bin-Sufian
Copy link
Contributor Author

I don't quite get the new ordering. The record button seems out of place. In general, I think the help content needs an overhaul. For example, the save menu descriptions are redundant. The grid menu is incomplete. The right click menu probably needs its own slide. et al.

@walterbender I have added the changes. Please review.

@Ubayed-Bin-Sufian Ubayed-Bin-Sufian marked this pull request as ready for review February 10, 2025 18:32
js/turtledefs.js Outdated
_("Grid"),
_("Turn on/off lines for cartesian or polar grids.") +
"<br/>" +
_("Turn on/off lines for musical notations"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Turn on/off music staffs." ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That would be great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look.

@Ubayed-Bin-Sufian Ubayed-Bin-Sufian force-pushed the improve_help_widget branch 2 times, most recently from 310246d to fa63f5c Compare February 10, 2025 19:01
@walterbender
Copy link
Member

Getting close.

A few issues:

Screenshot From 2025-02-10 15-38-20

Record is the only icon that is black instead of gray. Why?

Screenshot From 2025-02-10 15-39-02

Wrong icon on the theme selector

Screenshot From 2025-02-10 15-40-50

Maybe we want to add a slide with this pie menu before showing the copy/paste/delete slides.

Screenshot From 2025-02-10 15-41-09

We probably want to add this one too... and then add slides for the select area button (which only appears on this menu).

@Ubayed-Bin-Sufian
Copy link
Contributor Author

@walterbender I have added the requested changes. Please review.

@walterbender
Copy link
Member

This is a big improvement. I think we can sort out some issues with the piemenu artwork in a separate PR. But is there one more slide that needs to be added? The select button that only appears on the Canvas piemenu? I don't think there is any help for that one. It should be included after the Canvas piemenu slide.

@Ubayed-Bin-Sufian
Copy link
Contributor Author

Ubayed-Bin-Sufian commented Feb 13, 2025

This is a big improvement. I think we can sort out some issues with the piemenu artwork in a separate PR. But is there one more slide that needs to be added? The select button that only appears on the Canvas piemenu? I don't think there is any help for that one. It should be included after the Canvas piemenu slide.

The select button is moved at the end of canvas piemenu slides and included in advanced mode. Also, canvas piemenu will only display in advanced mode too.

@walterbender walterbender merged commit 1d64461 into sugarlabs:master Feb 13, 2025
4 checks passed
@Ubayed-Bin-Sufian Ubayed-Bin-Sufian deleted the improve_help_widget branch February 14, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants