test suite for js/turtledefs.js and js/protoblocks.js

[omsuneri]

@walterbender I had created test suite for js/turtledefs.js and js/protoblocks.js

[omsuneri]

@walterbender i m stuck and getting the error in two tests of the turtledefs.js
not getting the desired output :(
should i add those in the test file by commenting out as if someone finds the way can make them work as i tried a lot but unable to debug the cause of error
what would you say ??
or should left this test partially completed ??

[walterbender]

Which specific tests are failing?

[omsuneri]

@walterbender these are the tests

[omsuneri]

@walterbender i ll try again by force mocking the getMainToolbarButtonNames.... lets keep it draft till then

[walterbender]

(1) I am not sure that those functions are actually used anywhere. Maybe they are deprecated?
(2) the button names are lower case in the arrays being indexed.
(3) the button names you are testing for are not in the list.

[omsuneri]

@walterbender I tried with force mocking and it works well pushing changes soon

[omsuneri]

@walterbender i had added 2 more tests which are earlier failing

[walterbender]

Maybe I am missing something, but I don't understand why we need to mock the toolbar arrays. Any why are you testing for button names that don't exist?

[omsuneri]

@walterbender do we need more changes in these tests

[omsuneri]

@walterbender actually i think i must separate the tutledefs and protoblocks test in two separate PR as
when i go through to the files i found those in exported so i think about creating tests for those too but if you want i can remove them as well what do you think ??

[walterbender]

Please make separate PRs as I am getting a bit lost in this one.

[omsuneri]

@walterbender fine i ll make it now