Skip to content

Resolves Volume Bug#4372

Closed
falgun143 wants to merge 0 commit intosugarlabs:masterfrom
falgun143:master
Closed

Resolves Volume Bug#4372
falgun143 wants to merge 0 commit intosugarlabs:masterfrom
falgun143:master

Conversation

@falgun143
Copy link
Member

@falgun143 falgun143 commented Feb 9, 2025

@walterbender @pikurasa please review

  1. Removed the code causing the bug and eliminated unused functions.
  2. Replaced tempSynth with synth, as previously tempSynth = instruments[turtle]["electronic synth"] was hardcoded. Now we use the specific instrument name, where synth = instruments[turtle][instrumentName].

@falgun143 falgun143 marked this pull request as draft February 9, 2025 18:23
@walterbender
Copy link
Member

walterbender commented Feb 9, 2025

I am not sure what the "bug" is you refer to in your commit message.

@falgun143 falgun143 closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@falgun143 @walterbender