Merged
Conversation
js/__tests__/abc.test.js
Outdated
| "L:1/16\n"+ | ||
| "M:C\n"+ | ||
| "K:CMAJOR\n"+ | ||
| "G^ 4 G^4 F 4 F4 G^ 2 G^8 \n"; |
Member
There was a problem hiding this comment.
strange that sometimes there is a space before the octave number and sometimes not. Is this predicable? if not, maybe we need to use a regex to do the matching?
Member
Author
There was a problem hiding this comment.
Okay sir, I will look into it. If we can apply regex here I will do so.
Member
There was a problem hiding this comment.
Maybe you can investigate why the spaces are appearing that way before doing any additional coding. It is unexpected.
Member
Author
|
@walterbender Sir there was an extra line (at 337 abc.js) to add a space. I removed that line. Now the notation looks like this :->
|
Member
|
Thanks for tracking that down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for abc.js have been implemented.
@walterbender Please check this PR.