Fix: Preloading Fallback Font for slower connections#4415
Merged
walterbender merged 1 commit intosugarlabs:masterfrom Feb 16, 2025
Merged
Fix: Preloading Fallback Font for slower connections#4415walterbender merged 1 commit intosugarlabs:masterfrom
walterbender merged 1 commit intosugarlabs:masterfrom
Conversation
Member
|
Works, except sometimes it doesn't? |
Contributor
Author
|
@walterbender Been trying to reproduce any issue, can't seem to find any. I have tried multiple times and different browsers, it seems to work fine. Any tips to reproduce this issue? and anything in the console log? |
Member
|
I will try to reproduce it. |
Member
|
I cannot reproduce the error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #4413 and includes changes to improve the loading performance of web pages by preloading fonts.
On slower connections, the material-icons.woff2 font would be loaded later, so the font is preloaded, and is then fetched from disk cache now.
Before
Screen.Recording.2025-02-16.130630.mp4
After
Screen.Recording.2025-02-16.131220.mp4
Performance improvements:
index.html: Added alinktag to preload thematerial-icons.woff2font.planet/index.html: Added alinktag to preload thematerial-icons.woff2font.