Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing language Dropdown for Dark Mode #4424

Closed
wants to merge 2 commits into from

Conversation

AliyanA1
Copy link
Contributor

Customizing the background color of language dropdown content to match dark mode settings. This adjustment not only improves readability but also ensures that interface remains visually cohesive and user-friendly

before:
Screenshot from 2025-02-17 19-16-48

after:
Screenshot from 2025-02-17 19-41-07

@Commanderk3
Copy link
Contributor

Commanderk3 commented Feb 17, 2025

The dropdown menu had colors for dark mode. I think it was removed because of recent dark mode to theme box changes.
@AliyanA1 perhaps you can apply styles for other drop-down menus as well in this branch.
I think you should keep the bg-color a bit darker to distinguish itself from the canvas color.

@arjunjayan999
Copy link
Contributor

@AliyanA1 check this PR #4401 , go to themes.css line 70 to 80, you will find the original styling which was removed while I was redesigning the theme dropdown (they both were using the same dropdown, so was causing issue), but if you apply these styling again, it would work

@AliyanA1
Copy link
Contributor Author

hi @arjunjayan999 Thanks for pointing that out! 😊 I'll check PR #4401 and review the original styles in themes.css (lines 70-80).
Since those styles were removed due to conflicts with the theme dropdown redesign, I'll make sure that reapplying them won't reintroduce any issues. If needed, I’ll tweak the styles to keep the translation dropdown visually consistent without affecting other UI elements.

@AliyanA1
Copy link
Contributor Author

hi @Commanderk3 Thanks for the insights! 😊
I understand that the dropdown originally had dark mode colors, and they might have been removed due to the recent theme box changes. My goal was to ensure that the background color blends well with dark mode while maintaining consistency with other UI elements.

I believe the dark color I chose already aligns well with the overall background and theme, keeping the UI visually cohesive. However, if there’s a strong preference for a slightly darker shade, I’m happy to discuss and find a balance.

@AliyanA1 AliyanA1 closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants