Fix: Fixed the save menu not working after mode change #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arjunjayan999 Yes, this should work. The problem was not with Save WAV. |
|
@walterbender please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #4420 where the save menu was not functioning after mode changes. It will only work if you refresh the page with that mode.
For ex: if you are in beginner mode, and the page loads, only the beginner mode save menu would work and not the advanced menu.
Similarly, if you are in advanced mode, and the page loads, only the advanced mode save menu would work and not the beginner menu.
Probable cause was not handling rendering of save icons on mode switch.
Note: This issue is also addressed in PR #4401
Before
Screen.Recording.2025-02-17.201131.mp4
After
Screen.Recording.2025-02-17.200838.mp4