Refactor: Moved inline styles to external CSS classes-02#4454
Closed
Vaibhav701161 wants to merge 2 commits intosugarlabs:masterfrom
Closed
Refactor: Moved inline styles to external CSS classes-02#4454Vaibhav701161 wants to merge 2 commits intosugarlabs:masterfrom
Vaibhav701161 wants to merge 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
Did you test this? The palettes don't appear for me in Firefox. |
Contributor
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
Contributor
|
Closed pull request due to inactivity for more than 63 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4374
Description:
This PR refactors palette.js by migrating inline styles to external CSS classes. The changes improve maintainability, reusability, and adherence to best practices by separating concerns between JavaScript and styling.
Changes Made:
Removed inline styles applied using element.setAttribute("style", "...").
Introduced appropriate CSS classes in the stylesheet.
Updated palette.js to use classList.add() instead of inline styles.