Add Hover Effects to Confirmation Modal Buttons#4473
Merged
walterbender merged 6 commits intosugarlabs:masterfrom Mar 3, 2025
AliyanA1:master
Merged
Add Hover Effects to Confirmation Modal Buttons#4473walterbender merged 6 commits intosugarlabs:masterfrom AliyanA1:master
walterbender merged 6 commits intosugarlabs:masterfrom
AliyanA1:master
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
Do these color work for dark mode too? Shouldn't they be defined either in platformstyle.js or css? |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
1 similar comment
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@walterbender Thanks for the feedback! I’ve updated the code to define the hover colors (blueButtonHover and cancelButtonHover) in platformstyle.js under both light and dark themes. This ensures consistency and proper adaptation to dark mode. I’ve tested it in both modes, and the colors work well with the existing theme. Let me know if there’s anything else to tweak! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced the confirmation modal in renderClearConfirmation by adding smooth hover effects to the 'Confirm' and 'Cancel' buttons. The 'Confirm' button darkens and the 'Cancel' button on hover, improving user feedback and visual appeal.
simplescreenrecorder-2025-02-28_22.10.22.mp4