Skip to content

add: added new tests in synthutils#4475

Merged
walterbender merged 3 commits intosugarlabs:masterfrom
falgun143:add_newtests
Mar 1, 2025
Merged

add: added new tests in synthutils#4475
walterbender merged 3 commits intosugarlabs:masterfrom
falgun143:add_newtests

Conversation

@falgun143
Copy link
Member

@falgun143 falgun143 commented Feb 28, 2025

Resolves #4474.

  1. Added new tests in synthutils.test.js
  2. Added checks in setSynthVolume function.
  3. Made some cleanups and moved setVolume of SetMasterVolume function(in Synthutils.js) in the "no connections" code, as setVolume should be triggered only in the no-connections condition.

@walterbender please review.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2025

✅ All Jest tests passed! This PR is ready to merge.

test("should handle edge case with volume set to 100", () => {
setMasterVolume(100);
test("should handle edge case with volume set to 100 with connections", () => {
setMasterVolume(100,"c0","c1");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connections are ints

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2025

✅ All Jest tests passed! This PR is ready to merge.

@falgun143
Copy link
Member Author

@walterbender done.

@walterbender walterbender merged commit 3ad82d8 into sugarlabs:master Mar 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not testing the functions in synthtutils.js thoroughly

2 participants