test: fix the test of toolabar and the planet#4490
test: fix the test of toolabar and the planet#4490walterbender merged 3 commits intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
Thank you for looking into this Ajeet, were the tests broken due to some recent PRs? Earlier all tests ran fine. |
|
@BeNikk Actually, I don't know which commit introduced this. I ran the tests and found it failing. |
|
Since the Planet had been down, I am not sure this test would ever have run properly. Now that the Planet is back up, we can sort things out. |
|
@walterbender Actually, this issue is related only to the frontend, i.e., the icon, text, etc., and is independent of the functionality of the planet. |
|
@walterbender @apsinghdev Actually when i wrote this test for planet, it was redirecting the user to planet page by the click of the icon and ensuring whether the page exist or not. |
|
@BeNikk If you run it now, it breaks. Try to run the cypress test and let me know if it breaks to your side or not? |
|
On the latest pull, all the tests were running fine on my end, Strange! |
|
The tests pass on my system. |
|
@walterbender @BeNikk Can you please confirm that I am running it the same way as you do? Screen.Recording.2025-03-04.at.9.23.49.PM.mov |
|
I think you have not started your server in the background as the tests were skipped, MB should be running locally before running these tests |
|
When I run |
|
I am not sure of this, when i don't start the server i get result something similar to what ajeet sees |
|
@BeNikk Still the same result. testss.mp4 |
Have you checked the terminal after that process? |
|
@apsinghdev I think loading time in different operating systems and browsers might differ slightly and because of that tests are failing, what do you think, I'm using an ubuntu machine |
I am using mac and it's dev env is pretty much the same as ubuntu as it's based on Unix. Also we are using a chromium image for testing that is the same on each machine ig. |
|
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender All the cypress tests are passing. Please take a look. |
|
Still a few minor linting issues here. |
|
@walterbender fixed a conflict. please have a look again! |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
cypress/e2e/main.cy.js
Outdated
| }); | ||
|
|
||
| cy.window().then((win) => { | ||
| win.document.getElementById("planet-iframe").style.display = 'block'; |
There was a problem hiding this comment.
Could you please use double quotes?
There was a problem hiding this comment.
fixed it. please take a look.
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender Please take a look at this. I guess it's ready. |
4 participants
fixes: #4489
This PR fixes the tests related to the toolbar and the planet.
@walterbender Please have a look.