Skip to content

Remove Unused Volo Configuration#4499

Merged
walterbender merged 1 commit intosugarlabs:masterfrom
Ubayed-Bin-Sufian:remove_volo
Mar 21, 2025
Merged

Remove Unused Volo Configuration#4499
walterbender merged 1 commit intosugarlabs:masterfrom
Ubayed-Bin-Sufian:remove_volo

Conversation

@Ubayed-Bin-Sufian
Copy link
Copy Markdown
Contributor

@Ubayed-Bin-Sufian Ubayed-Bin-Sufian commented Mar 5, 2025

Summary

This PR removes the unused Volo configuration from the codebase.

Methods Used for Verification

1. Searched for Imports in the Codebase

a. Use VS Code's Global Search

  • Searched for require('domReady') or define(['domReady'], function(...) { ... })but found no occurrences.
  • Searched for require('webL10n') or define(['webL10n'], function(...) { ... })but found no occurrences.

b. Checked Volo Usage

  • Used VS Code's Global Search to check for any references to Volo in the codebase but found none.

2. Manually Checked Package References

  • Confirmed that Volo is not listed in dependencies or devDependencies.

3. After removal

npm install
npm run dev

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2025

✅ All Jest tests passed! This PR is ready to merge.

@Ubayed-Bin-Sufian Ubayed-Bin-Sufian changed the title remove unused Volo configuration Remove Unused Volo Configuration Mar 5, 2025
@Ubayed-Bin-Sufian Ubayed-Bin-Sufian marked this pull request as ready for review March 5, 2025 18:09
@Ubayed-Bin-Sufian
Copy link
Copy Markdown
Contributor Author

@walterbender, could you kindly review this PR? I have followed the steps outlined above and also discussed the matter with @apsinghdev. Looking forward to your feedback. Thanks!

@walterbender
Copy link
Copy Markdown
Member

Did you try running the server and checking to ensure translation still works? (I suspect it will, but since there was a reference to webl18n we should confirm.

@walterbender walterbender merged commit f89f458 into sugarlabs:master Mar 21, 2025
5 checks passed
sa-fw-an pushed a commit to sa-fw-an/musicblocks that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants