Modernize Music Processing Components and Remove Deprecated Code#4513
Modernize Music Processing Components and Remove Deprecated Code#4513lakshyeahh wants to merge 1 commit intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@lakshyeahh can you just make a video for this functionality it will be nice to have a demo for easier understanding |
|
Sorry. Can you please explain what you are trying to do? Why are you restoring the deprecated rest block? We have a "silence" block we use instead. What is going on with the Note duration/velocity block? (It doesn't work for me at least in my testing.) What is your goal? Re ADSR, the place we enable that is in the timbre widget. How does one access the changes you made in Singer? |
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
|
Closed pull request due to inactivity for more than 63 days. |
Singer Class Modernization
RestBlock Modernization
NoteBlock Modernization
Technical Details
Testing
The changes have been tested for:
Closes #4502 - Modernize music processing components