Skip to content

Modernize Music Processing Components and Remove Deprecated Code#4513

Closed
lakshyeahh wants to merge 1 commit intosugarlabs:masterfrom
lakshyeahh:modernize-music-components
Closed

Modernize Music Processing Components and Remove Deprecated Code#4513
lakshyeahh wants to merge 1 commit intosugarlabs:masterfrom
lakshyeahh:modernize-music-components

Conversation

@lakshyeahh
Copy link
Copy Markdown

  1. Singer Class Modernization

    • Replaced deprecated array-based envelope properties (attack[], decay[], sustain[], release[]) with a modern Map-based system
    • Added proper envelope management methods (setEnvelope, getEnvelope, clearEnvelope)
  2. RestBlock Modernization

    • Removed deprecated flag and implemented proper block formation
    • Added proper parameter handling and validation
  3. NoteBlock Modernization

    • Complete rewrite with modern envelope control support
    • Added velocity parameter for better note control
    • Implemented proper timing using the new envelope system
    • Added automatic resource cleanup

Technical Details

  • Note blocks now have proper ADSR (Attack, Decay, Sustain, Release) envelope control

Testing

The changes have been tested for:

  • Basic note playback functionality
  • Integration with existing music blocks

Closes #4502 - Modernize music processing components

@github-actions
Copy link
Copy Markdown
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@omsuneri
Copy link
Copy Markdown
Member

@lakshyeahh can you just make a video for this functionality it will be nice to have a demo for easier understanding

@walterbender
Copy link
Copy Markdown
Member

Sorry. Can you please explain what you are trying to do? Why are you restoring the deprecated rest block? We have a "silence" block we use instead. What is going on with the Note duration/velocity block? (It doesn't work for me at least in my testing.) What is your goal? Re ADSR, the place we enable that is in the timbre widget. How does one access the changes you made in Singer?

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions Bot added the Stale label May 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Closed pull request due to inactivity for more than 63 days.

@github-actions github-actions Bot closed this May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup and Modernize Deprecated Music Processing Components

3 participants