Added language search functionality#4529
Closed
AnvitaPrasad wants to merge 1 commit intosugarlabs:masterfrom
Closed
Added language search functionality#4529AnvitaPrasad wants to merge 1 commit intosugarlabs:masterfrom
AnvitaPrasad wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
@AnvitaPrasad it nice to have this feature but i m not aware how much this will impact @walterbender what do you think ?? |
Member
|
I don't think switching languages is something people do regularly, so we don't need that level of optimization for it. However, it's still good to add some level of convenience for the user. |
Member
|
@therealharshit I m too thinking of that actually if I choose english as my language it remains constant for a long while untill I try some other language which is not usual let's see the Walter's response on this !! |
Member
|
We really do not need to add this complexity. |
Contributor
|
@AnvitaPrasad Please close this PR, as it is not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a search bar to the language selection dropdown, allowing users to quickly filter and find their preferred language instead of manually scrolling through the list. This improves accessibility and enhances the user experience, especially as more languages are added in the future.
Changes Introduced
Issue Fixed
Closes #4528
Screenshots
Screen.Recording.2025-03-14.at.1.32.45.AM.mov