Skip to content

Add print block to phrase maker widget stack for lyric#4532

Merged
walterbender merged 4 commits intosugarlabs:masterfrom
therealharshit:feat/phrase-maker
Apr 30, 2025
Merged

Add print block to phrase maker widget stack for lyric#4532
walterbender merged 4 commits intosugarlabs:masterfrom
therealharshit:feat/phrase-maker

Conversation

@therealharshit
Copy link
Member

Initially to add lyrics in phrase maker we need to first manually add a print block to the phrase maker widget stack.
This PR adds a print block to the phrase maker widget stack by default.

Video:

print-block-in-phraseMaker.mp4

@walterbender What do you think?

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@therealharshit
Copy link
Member Author

@Commanderk3 You worked on this feature, so I think it's good to have your opinion too.

@Commanderk3
Copy link
Member

Sure, I mean users will be aware of the lyrics feature so it's a good addition to the default stack.

@walterbender
Copy link
Member

I have my doubts about this. But let's have @pikurasa chime in. And for sure, we should make sure this is well documented in the guide.

@pikurasa
Copy link
Collaborator

I think it would makes sense to be default in "Advanced Mode". It would help discoverability, I think.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@therealharshit
Copy link
Member Author

@walterbender I have made the changes as suggested by Devin.
But the transition from "Beginner" to "Advance" mode is not smooth and require a refresh to reflect changes.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

use lowercase for user-facing string
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@walterbender walterbender merged commit 893d16c into sugarlabs:master Apr 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants