Add print block to phrase maker widget stack for lyric#4532
Add print block to phrase maker widget stack for lyric#4532walterbender merged 4 commits intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@Commanderk3 You worked on this feature, so I think it's good to have your opinion too. |
|
Sure, I mean users will be aware of the lyrics feature so it's a good addition to the default stack. |
|
I have my doubts about this. But let's have @pikurasa chime in. And for sure, we should make sure this is well documented in the guide. |
|
I think it would makes sense to be default in "Advanced Mode". It would help discoverability, I think. |
4037443 to
a935775
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender I have made the changes as suggested by Devin. |
|
✅ All Jest tests passed! This PR is ready to merge. |
use lowercase for user-facing string
|
✅ All Jest tests passed! This PR is ready to merge. |
Initially to add lyrics in phrase maker we need to first manually add a print block to the phrase maker widget stack.
This PR adds a print block to the phrase maker widget stack by default.
Video:
print-block-in-phraseMaker.mp4
@walterbender What do you think?