Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving ESLint Issues on the js/ directory and .eslintrc.json for proper linting #4548

Merged
merged 6 commits into from
Mar 20, 2025

Conversation

omsuneri
Copy link
Member

@omsuneri omsuneri commented Mar 17, 2025

@walterbender when i tried running npx eslint --debug js (debugging the eslint over js directory)
i figured out many errors and potential warnings related to linting in many of the files
Screenshot 2025-03-17 at 2 26 45 PM
so in this PR i m doing the following things

  1. Parser Update: Replaced "babel-eslint" with "@babel/eslint-parser" (since babel-eslint is deprecated).

  2. Added "node": true to support GitHub Actions' Node.js runtime.

  3. resolving the "quotes", "indent", "quotes" error using npx eslint js --fix to fix some of the issues related to the linting

as a result of doing these changes the errors and warnings related to the eslint are resolved -->
image

Copy link

✅ All Jest tests passed! This PR is ready to merge.

Copy link

✅ All Jest tests passed! This PR is ready to merge.

@omsuneri
Copy link
Member Author

@walterbender when i try resolving the errors i found that the ESLint workflow is running absolutely fine just some thing we need to do to ignore the no-undef error will be resolving that to in this PR only also
the cause of workflow failure is the remaing error of no-undef and some others too
will be resolving soon

Copy link

✅ All Jest tests passed! This PR is ready to merge.

Copy link

✅ All Jest tests passed! This PR is ready to merge.

@omsuneri
Copy link
Member Author

omsuneri commented Mar 17, 2025

@walterbender I resolved all the eslint related issue in the js directory, also in this PR I turned off some of the unrequired rules of ESLint I checked through each and every file and resolve all the possible linting errors and warning and the workflow for ESLint is now working absoutely great please review this !!
Screenshot 2025-03-17 at 9 35 32 PM

@omsuneri
Copy link
Member Author

@walterbender right now our ESLint workflow is working fine as it is able to detect the linting issues on the changed files which our previous workflow is unable to do also as we have many linting issues priorly in the js dir we are unable to detect those but now you can view that in #4551 the linitng workflow is doing its works absolutely great and by merging this PR all the liniting issues of js dir also be resolved and we have a clean code !!

@omsuneri omsuneri changed the title Resolving Linting Issues on the js/ directory Resolving ESLint Issues on the js/ directory and .eslintrc.json for proper linting Mar 17, 2025
@Ubayed-Bin-Sufian
Copy link
Contributor

@omsuneri I think you were trying to mention #4548.

@omsuneri
Copy link
Member Author

@Ubayed-Bin-Sufian I didn't understand your point

@Ubayed-Bin-Sufian
Copy link
Contributor

@walterbender right now our ESLint workflow is working fine as it is able to detect the linting issues on the changed files which our previous workflow is unable to do also as we have many linting issues priorly in the js dir we are unable to detect those but now you can view that in #4551 the linitng workflow is doing its works absolutely great and by merging this PR all the liniting issues of js dir also be resolved and we have a clean code !!

In this comment, you have mentioned the PR 4551. Maybe you were trying point to #4548.

Copy link

✅ All Jest tests passed! This PR is ready to merge.

added missing ;
Copy link

✅ All Jest tests passed! This PR is ready to merge.

@walterbender walterbender merged commit 110c008 into sugarlabs:master Mar 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants