-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving ESLint Issues on the js/ directory and .eslintrc.json for proper linting #4548
Conversation
✅ All Jest tests passed! This PR is ready to merge. |
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender when i try resolving the errors i found that the ESLint workflow is running absolutely fine just some thing we need to do to ignore the no-undef error will be resolving that to in this PR only also |
✅ All Jest tests passed! This PR is ready to merge. |
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender I resolved all the eslint related issue in the js directory, also in this PR I turned off some of the unrequired rules of ESLint I checked through each and every file and resolve all the possible linting errors and warning and the workflow for ESLint is now working absoutely great please review this !! |
@walterbender right now our ESLint workflow is working fine as it is able to detect the linting issues on the changed files which our previous workflow is unable to do also as we have many linting issues priorly in the js dir we are unable to detect those but now you can view that in #4551 the linitng workflow is doing its works absolutely great and by merging this PR all the liniting issues of js dir also be resolved and we have a clean code !! |
@Ubayed-Bin-Sufian I didn't understand your point |
In this comment, you have mentioned the PR 4551. Maybe you were trying point to #4548. |
✅ All Jest tests passed! This PR is ready to merge. |
added missing ;
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender when i tried running

npx eslint --debug js
(debugging the eslint over js directory)i figured out many errors and potential warnings related to linting in many of the files
so in this PR i m doing the following things
Parser Update: Replaced "babel-eslint" with "@babel/eslint-parser" (since babel-eslint is deprecated).
Added "node": true to support GitHub Actions' Node.js runtime.
resolving the "quotes", "indent", "quotes" error using
npx eslint js --fix
to fix some of the issues related to the lintingas a result of doing these changes the errors and warnings related to the eslint are resolved -->
