Ensure nodes play properly in circular mode.#4570
Merged
walterbender merged 2 commits intosugarlabs:masterfrom Mar 23, 2025
Merged
Ensure nodes play properly in circular mode.#4570walterbender merged 2 commits intosugarlabs:masterfrom
walterbender merged 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
Please fix the lint errors. And please add a space after the if |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
Author
|
@walterbender done. |
Member
Author
|
@omsuneri review. |
sa-fw-an
pushed a commit
to sa-fw-an/musicblocks
that referenced
this pull request
Apr 29, 2025
* Ensure nodes play properly in circular mode. * fixed lint warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@walterbender In PR #4551, the functionality works fine in table mode. However, in circular mode, it throws an error because docById("pitchNumber_" + i); is only loaded in table mode and not in circular mode