jest test for toolbar.js#4593
Merged
walterbender merged 3 commits intosugarlabs:masterfrom Apr 1, 2025
Merged
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
Could you please fix the single-to-double-quote issue picked up by lint? |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
Author
I have fixed it. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
sa-fw-an
pushed a commit
to sa-fw-an/musicblocks
that referenced
this pull request
Apr 29, 2025
* jest test for toolbar.js * linting * license
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some changes in toolbar.js that do not create any bugs (at least based on my testing).
renderNewProjectConfirmation() was exposed outside, so whenever toolbar.js was loaded, it would run.
@walterbender, Please review this PR at your convenience.