[Optimization] Optimize DOM - improve the performance aiwidget#4601
Closed
Ajeett01 wants to merge 1 commit intosugarlabs:masterfrom
Closed
[Optimization] Optimize DOM - improve the performance aiwidget#4601Ajeett01 wants to merge 1 commit intosugarlabs:masterfrom
Ajeett01 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
Not sure I understand this one. You define a const that is never used. |
Contributor
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
Contributor
|
Closed pull request due to inactivity for more than 63 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue : #4461
Repeated calls to document.getElementsByClassName, document.querySelectorAll, etc., without caching the results.
In aiwidget.js, the same calculations are performed repeatedly in loop.
Many event listeners are added without being removed when components are destroyed.