Fix Home button placeholder text#4603
Closed
AnvitaPrasad wants to merge 2 commits intosugarlabs:masterfrom
Closed
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@walterbender @omsuneri pls review. Thanks. |
Member
|
the [HOME] is the shortcut key name. I think it should be present in the hover text. |
Member
|
@walterbender @AnvitaPrasad I m bit confused with the backup file changes why they seem to be appear ?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4602
Description
Removed the placeholder "[HOME]" text from the Home button for a cleaner UI. The button now displays just "Home" instead of "Home [HOME]".
Changes made
Updated the Home button label in js/activity.js to remove the redundant placeholder text
Fixed in both the button creation and menu item references
Screenshot