Add documentation for frequency display in Sampler widget#4622
Merged
walterbender merged 2 commits intosugarlabs:masterfrom Apr 20, 2025
Merged
Add documentation for frequency display in Sampler widget#4622walterbender merged 2 commits intosugarlabs:masterfrom
walterbender merged 2 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
Maybe it would make more sense to use A instead of C. A is 110, 220, 440, 880... no decimals to worry about. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
Makes sense. Updated to use A instead of C |
sa-fw-an
pushed a commit
to sa-fw-an/musicblocks
that referenced
this pull request
Apr 29, 2025
…4622) * Add documentation for frequency display in Sampler widget * Update documentation to use A notes as examples --------- Co-authored-by: Anvita Prasad <cs23b1059.iiitdm.ac.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the frequency display feature implemented #4615.