rafactor from html4 to html5#4655
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
This looks good. I just see one issue -- haven't looked into the root cause -- in that the piemenu is appearing on the bottom-left corner of the screen. It should be hidden.
|
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender fixed it |
|
Noticed one other issue. When you open-then-close the aux menu, the canvas is not sized properly. |
|
@walterbender this seems to be some weird issue, where there is a slight difference in how the tag is handled in html4 vs html5. I am working on a fix tho, will update as soon as possible. |
…sa1/musicblocks into port-from-htmlv4-to-v5 merging remote local fork branch
|
✅ All Jest tests passed! This PR is ready to merge. |
|
restructured a bit, the aux menu works fine now. |
Glad to see improvement in performance and loading times. Please provide a comparison between the loading times of the current master branch and the branch created by you. |
|
Since this is a very lightweight web app, there is not a significant improvement in usual performance, but on the initial load time, there is a 1-1.5 second difference for a first time user, visible from the naked eye. |
|
Works well. Thx. |
My pleasure |
* rafactor from html4 to html5 * fixed wheelDiv's visibility * fixed the auxillary menu problem
3 participants
name: refactor from html v4 to v5
about: issue #4641
Description
This PR refactors the project's outdated html v4 to html v5 with all the correct semantic tags, removes duplicate entries for links, title, meta tags and ids previously present.
After
Related Issue
fixes #4641
Changes Made
Checklist
Thank you for contributing to our project! We appreciate your help in improving it.
📚 See contributing instructions.
🙋🏾🙋🏼 Questions: Community Matrix Server.