Skip to content

Fix Sequential Note Playback in Simple Tuplet Block #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ganasekhar-gif wants to merge 5 commits into from
Closed

Fix Sequential Note Playback in Simple Tuplet Block #4660

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2954250
Fix simple tuplet block to play notes sequentially
Ganasekhar-gif Apr 28, 2025
bb87db1
Fix tuplet note delay calculation to play notes sequentially
Ganasekhar-gif Apr 30, 2025
34b3ecc
Fixed overlapping notes in simple tuplet block; reused noteBeatValue …
Ganasekhar-gif May 3, 2025
1961c82
Updated delay timing
Ganasekhar-gif May 17, 2025
d8e60ef
Updated delay timing
Ganasekhar-gif May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions js/blocks/RhythmBlockPaletteBlocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,8 @@ function setupRhythmBlockPaletteBlocks(activity) {
arg1 = args[1];
}

const noteBeatValue = (1 / arg1) * activity.turtles.ithTurtle(turtle).singer.beatFactor;
const totalDuration = (1 / arg1) * activity.turtles.ithTurtle(turtle).singer.beatFactor;
Copy link
Member

@therealharshit therealharshit Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just changed the variable name.

const noteBeatValue = totalDuration / arg0;
if (logo.inMatrix || logo.tuplet) {
logo.phraseMaker.addColBlock(blk, arg0);
if (logo.tuplet) {
Expand Down Expand Up @@ -977,7 +978,7 @@ function setupRhythmBlockPaletteBlocks(activity) {
const bpmFactor =
TONEBPM / tur.singer.bpm.length > 0 ? last(tur.singer.bpm) : Singer.masterBPM;

const beatValue = bpmFactor / noteBeatValue / arg0;
const beatValue = noteBeatValue;
Copy link
Member

@therealharshit therealharshit Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beatValue is used as a parameter and you have updated it.


const __rhythmPlayNote = (thisBeat, blk, turtle, callback, timeout) => {
setTimeout(
Expand All @@ -997,8 +998,10 @@ function setupRhythmBlockPaletteBlocks(activity) {
__callback = null;
}

const delay = i * beatValue * 1000;
Copy link
Member

@therealharshit therealharshit Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unused declaration.


__rhythmPlayNote(
noteBeatValue * arg0,
noteBeatValue,
blk,
turtle,
__callback,
Expand Down