Skip to content

remove: delete obsolete cache.appcache file#4664

Closed
Ubayed-Bin-Sufian wants to merge 2 commits intosugarlabs:masterfrom
Ubayed-Bin-Sufian:chore/remove_cache.appcache
Closed

remove: delete obsolete cache.appcache file#4664
Ubayed-Bin-Sufian wants to merge 2 commits intosugarlabs:masterfrom
Ubayed-Bin-Sufian:chore/remove_cache.appcache

Conversation

@Ubayed-Bin-Sufian
Copy link
Contributor

@Ubayed-Bin-Sufian Ubayed-Bin-Sufian commented Apr 29, 2025

Fixes: #4665

Summary

This PR removes the deprecated cache.appcache file from the project. AppCache is an obsolete feature that is no longer supported in modern browsers due to security and performance concerns.

The removal aligns with best practices outlined in the following resources:

  1. Chrome Developer Lighthouse: AppCache Manifest

  2. Meteor Documentation: AppCache Package

  3. Chromium Blink Dev Discussion on AppCache Deprecation

We have already migrated to a Service Worker-based approach for offline functionality, as implemented in sw.js, making the AppCache file redundant.

Checklist

  • Removed cache.appcache from the codebase
  • Verified there are no remaining references to AppCache

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@Ubayed-Bin-Sufian
Copy link
Contributor Author

@walterbender, could you kindly advise which documentation file would be most appropriate for adding a note about the removal of the deprecated file?

@walterbender
Copy link
Member

Maybe the Readme in the lib dir?

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@Ubayed-Bin-Sufian Ubayed-Bin-Sufian marked this pull request as ready for review April 30, 2025 20:32
@Ubayed-Bin-Sufian
Copy link
Contributor Author

@walterbender Please review.

@walterbender
Copy link
Member

I thought you were going to add info about how/when to deprecate packages to the Readme. We don't need to add this specific explanation. It should be in the commit message.

@Ubayed-Bin-Sufian Ubayed-Bin-Sufian force-pushed the chore/remove_cache.appcache branch from 06fa60a to 93907e8 Compare May 3, 2025 16:34
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2025

✅ All Jest tests passed! This PR is ready to merge.

@Ubayed-Bin-Sufian
Copy link
Contributor Author

@walterbender I misunderstood. I suggest a change. Please review.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label Jul 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2025

Closed pull request due to inactivity for more than 63 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove cache.appcache

2 participants