Skip to content

Add musical examples of double-sharp and double-flat usage (#3855)#4675

Merged
walterbender merged 3 commits intosugarlabs:masterfrom
JaySoni1:bcd
May 18, 2025
Merged

Add musical examples of double-sharp and double-flat usage (#3855)#4675
walterbender merged 3 commits intosugarlabs:masterfrom
JaySoni1:bcd

Conversation

@JaySoni1
Copy link
Contributor

@JaySoni1 JaySoni1 commented May 3, 2025

Fix: #3855 Add musical examples of double-sharp and double-flat usage

I have taken a simple and direct approach following the issue requirements:

  1. Added examples of G♯ Major, D♯ Major, and F♭ Major scales showing where double-sharps/flats occur
  2. Included the reference to Bartók's Mikrokosmos No. 136 as suggested
  3. Added brief explanations of why these notation choices are necessary

Fixes #3855

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2025

✅ All Jest tests passed! This PR is ready to merge.

@JaySoni1
Copy link
Contributor Author

JaySoni1 commented May 3, 2025

Hi @pikurasa ,
I have submitted a fix for issue #3855. All tests pass. Please review when possible.
Thanks!

@walterbender
Copy link
Member

I think the terminology is too advanced. For example, what are "correct intervallic relationships"? What is "stepwise motion" and why preserve it? What is "enharmonic"?

@JaySoni1
Copy link
Contributor Author

@walterbender Thank you for the feedback!
You're absolutely right . I will simplify the terminology and make the explanations more beginner-friendly.
-Intervallic relationships refer to the distances between notes.
-Stepwise motion means moving from one note to the next closest note.
-Enharmonic refers to notes that sound the same but are written differently (like G♯ and A♭).

I will revise the description to explain these terms more clearly or replace them with simpler language.
Would you like me to push the updated PR once I make these changes?

@walterbender
Copy link
Member

fine to revise this PR

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@JaySoni1
Copy link
Contributor Author

@walterbender I have revised the PR. Please review when you have a moment.
Thank you @walterbender for your guidance !

@walterbender
Copy link
Member

Getting closer. Still not sure what phrases like "theoretical clarity" and "logical structure" would mean to our users.

@JaySoni1
Copy link
Contributor Author

Examples of Double-Sharp and Double-Flat Usage

Double-sharps (𝄪) and double-flats (𝄫) are used in certain keys and advanced compositions to preserve correct scale structure or harmonic context. Here are a few examples:

  1. G♯ Major Scale

    • Notes: G♯, A♯, B♯, C♯, D♯, E♯, F𝄪
      -F𝄪 is used instead of G to keep the pattern of moving step by step through the musical alphabet (A to G).
  2. D♯ Major Scale

    • Notes: D♯, E♯, F𝄪, G♯, A♯, B♯, C𝄪
    • C𝄪 is written instead of D so that the note names follow the correct sequence and each letter is used only once.
  3. F♭ Major Scale

    • Notes: F♭, G♭, A♭, B𝄫, C♭, D♭, E♭
    • B𝄫 is used instead of A to preserve the proper spacing between scale steps.
  4. Béla Bartók’s Mikrokosmos No. 136 – "Whole-tone Scale"
    -This piece uses double-flats to keep the note names in the right order, even if some notes sound the same as others.

I have revised the explanation to make it simpler and more user-friendly.Does this version work better ?
I'm happy to make further changes based on your suggestions.

@walterbender
Copy link
Member

This version reads much better. Can you please revise your PR?

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@JaySoni1
Copy link
Contributor Author

@walterbender I have revised the PR. Please review when you have a moment.

@JaySoni1
Copy link
Contributor Author

@walterbender I noticed that a lint/test error is occur mentioning a missing file MediaBlocks.test.js. Since this doesn't seem related to my changes, I wanted to ask if I should address it or leave it as is. Please let me know how you would prefer I should proceed.

@walterbender walterbender merged commit 70f708b into sugarlabs:master May 18, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guide Improvement: Add some musical examples of when double-sharp / double-flat is most useful

2 participants