Add musical examples of double-sharp and double-flat usage (#3855)#4675
Add musical examples of double-sharp and double-flat usage (#3855)#4675walterbender merged 3 commits intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
I think the terminology is too advanced. For example, what are "correct intervallic relationships"? What is "stepwise motion" and why preserve it? What is "enharmonic"? |
|
@walterbender Thank you for the feedback! I will revise the description to explain these terms more clearly or replace them with simpler language. |
|
fine to revise this PR |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender I have revised the PR. Please review when you have a moment. |
|
Getting closer. Still not sure what phrases like "theoretical clarity" and "logical structure" would mean to our users. |
Examples of Double-Sharp and Double-Flat UsageDouble-sharps (𝄪) and double-flats (𝄫) are used in certain keys and advanced compositions to preserve correct scale structure or harmonic context. Here are a few examples:
I have revised the explanation to make it simpler and more user-friendly.Does this version work better ? |
|
This version reads much better. Can you please revise your PR? |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender I have revised the PR. Please review when you have a moment. |
|
@walterbender I noticed that a lint/test error is occur mentioning a missing file MediaBlocks.test.js. Since this doesn't seem related to my changes, I wanted to ask if I should address it or leave it as is. Please let me know how you would prefer I should proceed. |
Fix: #3855 Add musical examples of double-sharp and double-flat usage
I have taken a simple and direct approach following the issue requirements:
Fixes #3855