Guide Improvement: Add examples for double-sharp and double-flat usage in musical contexts (#3855)#4686
Closed
anandritishaa07 wants to merge 1 commit intosugarlabs:masterfrom
Closed
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
While I very much appreciate the inclusion of these examples, I think the overall discussion is a bit over the head of most of our users. Especially in that you introduce a number of terms that I don't think the average MB user would be familiar with: voice leading rules, enharmonically equivalence, theoretical key, preserve the correct intervals, theoretical spellings. I wonder if there isn't a way to explain this w/o these terms? |
Contributor
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
Contributor
|
Closed pull request due to inactivity for more than 63 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #3855 by enhancing the guide with concrete examples that illustrate practical usage of double-sharps and double-flats in musical notation. These additions aim to improve clarity for readers wondering when and why such accidentals appear in standard musical contexts.
Added Examples
Resources Used
Motivation
Musicians and learners often question the relevance of double accidentals. Adding these examples makes our documentation more pedagogical and concrete.
Let me know if anything needs refining!