Skip to content

enable gif-support#4694

Closed
Rishikesh63 wants to merge 1 commit intosugarlabs:masterfrom
Rishikesh63:gif-support
Closed

enable gif-support#4694
Rishikesh63 wants to merge 1 commit intosugarlabs:masterfrom
Rishikesh63:gif-support

Conversation

@Rishikesh63
Copy link

@Rishikesh63 Rishikesh63 commented May 20, 2025

This PR resolves issue #4560 by extending MediaBlock to support .gif files in addition to .png and .jpg. A hidden file input now accepts all common image formats, allowing students to import animated GIFs for their MusicBlocks projects .

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@walterbender
Copy link
Member

The gif files load but don't animate.

@Rishikesh63
Copy link
Author

@walterbender if i removed this part even then i am able to import images and gif
/**
* Represents a block that imports an image.
* @Class
* @extends ValueBlock
/
class MediaBlock extends ValueBlock {
/
*
* Constructs a MediaBlock instance.
* @constructor
*/
constructor() {
super("media", _("Media").toLowerCase());

        // Set palette and activity for the block
        this.setPalette("media", activity);
        this.beginnerBlock(true);

        // Set help string for the block
        this.setHelpString([
            _("The Media block is used to import an image."),
            "documentation",
            null,
            "turtleshell"
        ]);

        // Form block with image and output type
        this.formBlock({
            image: "images/load-media.svg",
            outType: "mediaout"
        });
    }
}.   

@Rishikesh63
Copy link
Author

i am asking which part of code is related to importing images

@Rishikesh63
Copy link
Author

@walterbender i comment out the mediablock.js to see is there any effect of this on media or not , i have seen there is not any effect of it

@walterbender
Copy link
Member

I am not sure how you would import an image (or use it) w/o the media block.

@github-actions
Copy link
Contributor

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label Jul 26, 2025
@github-actions
Copy link
Contributor

Closed pull request due to inactivity for more than 63 days.

@github-actions github-actions bot closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants