Fix simple tuplet sequential playback#4697
Closed
Ganasekhar-gif wants to merge 0 commit intosugarlabs:masterfrom
Ganasekhar-gif:fix-simple-tuplet-sequential-playback
Closed
Fix simple tuplet sequential playback#4697Ganasekhar-gif wants to merge 0 commit intosugarlabs:masterfrom Ganasekhar-gif:fix-simple-tuplet-sequential-playback
Ganasekhar-gif wants to merge 0 commit intosugarlabs:masterfrom
Ganasekhar-gif:fix-simple-tuplet-sequential-playback
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
I'll give you a detail review it in some time. But it looks like |
Author
|
Hi @therealharshit, Thanks for noticing! I did not intentionally update or install any dependencies for this fix. The changes to package-lock.json likely happened due to running some commands locally. I will revert the package-lock.json changes and update the PR shortly to keep it clean. Thanks for your patience! |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @therealharshit ,
Following up on my previous PR to the STupletBlock, I've made further changes to address the issue where all notes were previously being sent to the synth simultaneously without any delay between them. The latest update properly introduces a delay between each note so they are now played sequentially.
📹 Video demo: https://github.com/user-attachments/assets/9c4208b4-6ee3-4536-aea9-331d7e2625d9
Could you please confirm if this behavior is now correct?
Specifically:
• For a 7 1/4 block, should the 7 notes be played sequentially over 4 seconds total?
• Is this now working as expected?
• If not, could you please clarify what the expected timing and sequencing should be for a 7 1/4 or similar tuplet?
Previously, all notes were sent simultaneously due to a lack of proper timing. I've now fixed that by introducing per-note delays based on the total beat duration. I'm not committing the change yet—just sharing this to validate the behavior and avoid regressions elsewhere.
Thanks for your time and guidance!