Skip to content

Fix simple tuplet sequential playback#4697

Closed
Ganasekhar-gif wants to merge 0 commit intosugarlabs:masterfrom
Ganasekhar-gif:fix-simple-tuplet-sequential-playback
Closed

Fix simple tuplet sequential playback#4697
Ganasekhar-gif wants to merge 0 commit intosugarlabs:masterfrom
Ganasekhar-gif:fix-simple-tuplet-sequential-playback

Conversation

@Ganasekhar-gif
Copy link

@Ganasekhar-gif Ganasekhar-gif commented May 27, 2025

Hi @therealharshit ,

Following up on my previous PR to the STupletBlock, I've made further changes to address the issue where all notes were previously being sent to the synth simultaneously without any delay between them. The latest update properly introduces a delay between each note so they are now played sequentially.

📹 Video demo: https://github.com/user-attachments/assets/9c4208b4-6ee3-4536-aea9-331d7e2625d9

Could you please confirm if this behavior is now correct?
Specifically:
• For a 7 1/4 block, should the 7 notes be played sequentially over 4 seconds total?
• Is this now working as expected?
• If not, could you please clarify what the expected timing and sequencing should be for a 7 1/4 or similar tuplet?

Previously, all notes were sent simultaneously due to a lack of proper timing. I've now fixed that by introducing per-note delays based on the total beat duration. I'm not committing the change yet—just sharing this to validate the behavior and avoid regressions elsewhere.

Thanks for your time and guidance!

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@therealharshit
Copy link
Member

I'll give you a detail review it in some time.

But it looks like package-lock.json was update, did you install or update any dependencies for this fix?

@Ganasekhar-gif
Copy link
Author

Hi @therealharshit,

Thanks for noticing! I did not intentionally update or install any dependencies for this fix. The changes to package-lock.json likely happened due to running some commands locally.

I will revert the package-lock.json changes and update the PR shortly to keep it clean.

Thanks for your patience!

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants