Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@pikurasa could you please test? |
|
Thx. How many notes were in the clamp? |
There were eight. It seems like it does up to three notes the best. After that, it begins to drift. |
|
hmm. digging deeper, I think the issue is a bit different than I thought. It seems that the mis-sizing of the clamp is only an issue when the block scale is 1.5 (the default size). All the other sizes are integers. So what happens is that the block positions are calculated to .5 pixel precision but are being rendered at full pixel positions. I need to think about a solution. |
|
@pikurasa It is not perfect but I think it is better than before. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
I think the only way to fix this properly is to ensure that all block sizes, when multiplied by 1.5, are still integers. So all block sizes must be even numbers. |
|
I am going to take a different approach to this. |





We have had a long-standing issue with the calculation of the clamp size. When you have a long stack inside of a clamp, you will notice that the clamp is not quite large enough. It is a 0.25 pixel adjustment (at standard scale) per clamp slot to fix the issue.