fix(ci): prevent linter crash on deleted files#4952
Merged
walterbender merged 1 commit intosugarlabs:masterfrom Dec 31, 2025
Merged
fix(ci): prevent linter crash on deleted files#4952walterbender merged 1 commit intosugarlabs:masterfrom
walterbender merged 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4951
Description
This PR fixes a bug in the
Lint updated JavaScript filesworkflow where the CI fails with "No files matching the pattern" if a Pull Request deletes files (e.g.,electron-main.js).Root Cause
The
git diffcommand in the workflow was including deleted files in its output. ESLint then attempted to lint these non-existent files, causing a crash.Changes
.github/workflows/linter.ymlto include the--diff-filter=ACMRTflag.git diffonly returns Added, Copied, Modified, Renamed, or Type-changed files, explicitly excluding Deleted (D) files.Testing
Verified locally:
git diff --diff-filter=ACMRT --name-only HEAD~1 HEADand confirmed it returns an empty list instead of the deleted filename.